[coreboot-gerrit] Change in ...coreboot[master]: util/release: Test for rename(1) in genrelnotes
Patrick Georgi (Code Review)
gerrit at coreboot.org
Thu Dec 20 17:27:08 CET 2018
Hello Martin Roth,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/30340
to review the following change.
Change subject: util/release: Test for rename(1) in genrelnotes
......................................................................
util/release: Test for rename(1) in genrelnotes
It's a separate package on debian, so it may not be installed with perl.
Change-Id: Id82661e1d7e6a025f5b207e3bd61669abc32d328
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
M util/release/genrelnotes
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/30340/1
diff --git a/util/release/genrelnotes b/util/release/genrelnotes
index 0cc8b08..ee4bd25 100755
--- a/util/release/genrelnotes
+++ b/util/release/genrelnotes
@@ -26,7 +26,7 @@
# Check for tools
-if ! ( git --version && cloc --version ) > /dev/null 2>&1
+if ! ( git --version && cloc --version && rename --version ) > /dev/null 2>&1
then
echo "ERROR: cloc or git is not installed. Exiting"
exit 1
--
To view, visit https://review.coreboot.org/c/coreboot/+/30340
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id82661e1d7e6a025f5b207e3bd61669abc32d328
Gerrit-Change-Number: 30340
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/ca7ec7b1/attachment-0001.html>
More information about the coreboot-gerrit
mailing list