[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Add EC trigger events and acpi configs

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30281 )

Change subject: mb/google/hatch: Add EC trigger events and acpi configs
......................................................................


Patch Set 11:

(3 comments)

https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h 
File src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h:

https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@23 
PS7, Line 23: 	(EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED)        |\
> extra blank line not required.
Done


https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@79 
PS7, Line 79: #endif /* __BASEBOARD_EC_H__ */
> I am fine adding it later. But it would be good to ensure there is a tracking bug for it.
Ok, I have created bug 121306806 to track it


https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h 
File src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h:

https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h@28 
PS7, Line 28: 
> about the comment. there is no deep Sx on hatch.
Ok Done.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a86f609c269cb59e546fc7ba4ba032e5ea8341a
Gerrit-Change-Number: 30281
Gerrit-PatchSet: 11
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 16:01:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aamir Bohra <aamir.bohra at intel.com>
Comment-In-Reply-To: Furquan Shaikh <furquan at google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/b3250f7a/attachment.html>