[coreboot-gerrit] Change in ...coreboot[master]: qcs405: Add DRAM resources

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29954 )

Change subject: qcs405: Add DRAM resources
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://review.coreboot.org/#/c/29954/2/src/soc/qualcomm/qcs405/soc.c 
File src/soc/qualcomm/qcs405/soc.c:

https://review.coreboot.org/#/c/29954/2/src/soc/qualcomm/qcs405/soc.c@22 
PS2, Line 22: device_t 
Please, don't use device_t



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29954
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea79a942c297400c88aa205da713bcfcb8c51185
Gerrit-Change-Number: 29954
Gerrit-PatchSet: 2
Gerrit-Owner: nsekar at codeaurora.org
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: nsekar at codeaurora.org
Gerrit-Comment-Date: Thu, 20 Dec 2018 15:34:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/00f44279/attachment.html>