[coreboot-gerrit] Change in ...coreboot[master]: mainboard/google/mistral: Add support for Mistral

HAOUAS Elyes (Code Review) gerrit at coreboot.org
Thu Dec 20 16:33:23 CET 2018


HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29949 )

Change subject: mainboard/google/mistral: Add support for Mistral
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://review.coreboot.org/#/c/29949/2/src/mainboard/google/mistral/mainboard.c 
File src/mainboard/google/mistral/mainboard.c:

https://review.coreboot.org/#/c/29949/2/src/mainboard/google/mistral/mainboard.c@20 
PS2, Line 20: device_t
Please don't use device_t



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29949
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ecfad68bb50f42acf36f51bc3433add56597c3d
Gerrit-Change-Number: 29949
Gerrit-PatchSet: 2
Gerrit-Owner: nsekar at codeaurora.org
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: nsekar at codeaurora.org
Gerrit-Comment-Date: Thu, 20 Dec 2018 15:33:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/f1095767/attachment.html>


More information about the coreboot-gerrit mailing list