[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/i82801gx: Autodisable functions based on devicetree
Arthur Heymans (Code Review)
gerrit at coreboot.org
Thu Dec 20 13:30:24 CET 2018
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30244 )
Change subject: sb/intel/i82801gx: Autodisable functions based on devicetree
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/30244/11/src/mainboard/kontron/986lcd-m/romstage.c
File src/mainboard/kontron/986lcd-m/romstage.c:
https://review.coreboot.org/#/c/30244/11/src/mainboard/kontron/986lcd-m/romstage.c@219
PS11, Line 219: }
> Needs to be ported to ramstage. Or removed? I don't think secunet
> will ever rebase for this board again. So I wouldn't mind.
done in a follow-up patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/30244
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I83576599538a02d295fe00b35826f98d8c97d1cf
Gerrit-Change-Number: 30244
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Comment-Date: Thu, 20 Dec 2018 12:30:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/a4c9ceb3/attachment.html>
More information about the coreboot-gerrit
mailing list