[coreboot-gerrit] Change in ...coreboot[master]: mb/qemu-{i440fx, q35}: Use POSTCAR stage to load the ramstage
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Thu Dec 20 11:33:34 CET 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30332 )
Change subject: mb/qemu-{i440fx,q35}: Use POSTCAR stage to load the ramstage
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/30332/1/src/mainboard/emulation/qemu-i440fx/romstage.c
File src/mainboard/emulation/qemu-i440fx/romstage.c:
https://review.coreboot.org/#/c/30332/1/src/mainboard/emulation/qemu-i440fx/romstage.c@26
PS1, Line 26: struct postcar_frame pcf;
code indent should use tabs where possible
https://review.coreboot.org/#/c/30332/1/src/mainboard/emulation/qemu-i440fx/romstage.c@26
PS1, Line 26: struct postcar_frame pcf;
please, no space before tabs
https://review.coreboot.org/#/c/30332/1/src/mainboard/emulation/qemu-i440fx/romstage.c@26
PS1, Line 26: struct postcar_frame pcf;
please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/c/coreboot/+/30332
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id73632afbef1c7f0845153bc01c6c21e87386710
Gerrit-Change-Number: 30332
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 10:33:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/5977779d/attachment.html>
More information about the coreboot-gerrit
mailing list