[coreboot-gerrit] Change in ...coreboot[master]: mb/intel/kblrvp: Add helper function to get Board Id
PraveenX Hodagatta Pranesh (Code Review)
gerrit at coreboot.org
Thu Dec 20 10:41:51 CET 2018
Hello Subrata Banik, Boon Tiong Teo, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30306
to look at the new patch set (#5).
Change subject: mb/intel/kblrvp: Add helper function to get Board Id
......................................................................
mb/intel/kblrvp: Add helper function to get Board Id
Add 2 helper function get_board_id() & get_spd_index()
to read board id & spd index from EC.
Rename the old get_board_id() function to get_ec_boardinfo().
BUG=None
TEST= Tested on KBL RVP11, able to read the Board id (0x44)
and verified in serial logs. not verified on KBL RVP8.
Signed-off-by: Praveen hodagatta pranesh <praveenx.hodagatta.pranesh at intel.com>
Change-Id: Ie20bf0d45a3568c2c433e5b844bea86aac07c47d
---
M src/mainboard/intel/kblrvp/board_id.c
M src/mainboard/intel/kblrvp/board_id.h
M src/mainboard/intel/kblrvp/romstage.c
3 files changed, 25 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/30306/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/30306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie20bf0d45a3568c2c433e5b844bea86aac07c47d
Gerrit-Change-Number: 30306
Gerrit-PatchSet: 5
Gerrit-Owner: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh at intel.com>
Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo at intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/3493dc48/attachment.html>
More information about the coreboot-gerrit
mailing list