[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Enable H1 TPM support over SPI interface

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30210 )

Change subject: mb/google/hatch: Enable H1 TPM support over SPI interface
......................................................................


Patch Set 12:

(2 comments)

https://review.coreboot.org/#/c/30210/12/src/mainboard/google/hatch/Kconfig 
File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/30210/12/src/mainboard/google/hatch/Kconfig@31 
PS12, Line 31: DEVICETREE
> why inclusion of DEVICETREE is part of this CL?
I just arranged it alphabetically, there's a remove below.


https://review.coreboot.org/#/c/30210/12/src/mainboard/google/hatch/Kconfig@79 
PS12, Line 79: VARIANT_DIR
> -same ?
This too.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30210
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib63a0b473f632d91745102ebd01993e8d65b9552
Gerrit-Change-Number: 30210
Gerrit-PatchSet: 12
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 05:46:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik at intel.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/391074bb/attachment.html>