[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Add SoC and EC asl files in DSDT

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30282 )

Change subject: mb/google/hatch: Add SoC and EC asl files in DSDT
......................................................................


Patch Set 8:

(2 comments)

https://review.coreboot.org/#/c/30282/8/src/mainboard/google/hatch/Kconfig 
File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/30282/8/src/mainboard/google/hatch/Kconfig@15 
PS8, Line 15: SOC_INTEL_COFFEELAKE
shouldn't we select WHL ?


https://review.coreboot.org/#/c/30282/8/src/mainboard/google/hatch/dsdt.asl 
File src/mainboard/google/hatch/dsdt.asl:

https://review.coreboot.org/#/c/30282/8/src/mainboard/google/hatch/dsdt.asl@46 
PS8, Line 46: #if IS_ENABLED(CONFIG_CHROMEOS)
start from 0th column



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30282
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf1b1d7e34a7e863139c3583903f3b1e2cdc8da6
Gerrit-Change-Number: 30282
Gerrit-PatchSet: 8
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 04:56:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/a86eebe7/attachment.html>