[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/i82801gx: Autodisable functions based on devicetree

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30244 )

Change subject: sb/intel/i82801gx: Autodisable functions based on devicetree
......................................................................


Patch Set 10:

(1 comment)

I moved the PCIe coalescing part to a followup patch.
This should make the reviewing easier.
I based the coalescing implementation on the haswell/broadwell one as I found it more readable and easier to make common.

https://review.coreboot.org/#/c/30244/8/src/northbridge/intel/i945/early_init.c 
File src/northbridge/intel/i945/early_init.c:

https://review.coreboot.org/#/c/30244/8/src/northbridge/intel/i945/early_init.c@181 
PS8, Line 181: 	/* Set up all hardcoded northbridge BARs */
> hmmm, do it in southbridge_intel_i82801gx_ops. […]
Done



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30244
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I83576599538a02d295fe00b35826f98d8c97d1cf
Gerrit-Change-Number: 30244
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Comment-Date: Thu, 20 Dec 2018 01:07:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/e3386ff3/attachment.html>