[coreboot-gerrit] Change in ...coreboot[master]: cr50: Add probe command to poll Cr50 until DID VID is valid

[Jett Rink (Code Review)]

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30295 )

Change subject: cr50: Add probe command to poll Cr50 until DID VID is valid
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/30295/3/src/drivers/i2c/tpm/cr50.c 
File src/drivers/i2c/tpm/cr50.c:

https://review.coreboot.org/#/c/30295/3/src/drivers/i2c/tpm/cr50.c@476 
PS3, Line 476: *did_vid == CR50_DID_VID
will the i2c_read succeed by return the wrong DID_VID value? Should we just be looping on !rc and once we get any did_vid we return it (and the calling method will return an error instead)



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30295
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47c59a32378ad00336277e111e81ba8d2d63e69a
Gerrit-Change-Number: 30295
Gerrit-PatchSet: 3
Gerrit-Owner: Edward Hill <ecgh at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Edward Hill <ecgh at chromium.org>
Gerrit-Reviewer: Keith Short <keithshort at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Jett Rink <jettrink at chromium.org>
Gerrit-Comment-Date: Wed, 19 Dec 2018 18:02:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/4894893c/attachment.html>