[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/i82801gx: Autodisable functions based on devicetree

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30244 )

Change subject: sb/intel/i82801gx: Autodisable functions based on devicetree
......................................................................


Patch Set 8:

(2 comments)

https://review.coreboot.org/#/c/30244/8//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30244/8//COMMIT_MSG@12 
PS8, Line 12: This mostly reimplements what sandybridge does albeit a bit simpler.
> As usual, I would love to see common code. Any reason not to share code […]
RPFN works a little differently so not sure how that would work out, but it seems doable.


https://review.coreboot.org/#/c/30244/8//COMMIT_MSG@14 
PS8, Line 14: TESTED with PCIe coalescing (root port 0 disabled in devicetree)
> This is confusing because you reuse the term "coalescing" but what you […]
What are the benefits of actual coalescing over just moving things around to make the OS happy?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30244
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I83576599538a02d295fe00b35826f98d8c97d1cf
Gerrit-Change-Number: 30244
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Comment-Date: Wed, 19 Dec 2018 17:55:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/74587a36/attachment.html>