[coreboot-gerrit] Change in ...coreboot[master]: Documentation: Add disassembly guide for x220

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29936 )

Change subject: Documentation: Add disassembly guide for x220
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/29936/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/29936/2//COMMIT_MSG@7 
PS2, Line 7: Documentation: Add disassembly guide for x220
> Does it apply to all xx20 models? Otherwise please move it into a x220-specific file.
I don't like the xx syntax at all, I'll come up with something smarter in a separate commit.
correct would be x2x0 where to second x is a numeric, but the first is not...


https://review.coreboot.org/#/c/29936/2/Documentation/mainboard/lenovo/xx20_series.md 
File Documentation/mainboard/lenovo/xx20_series.md:

https://review.coreboot.org/#/c/29936/2/Documentation/mainboard/lenovo/xx20_series.md@60 
PS2, Line 60: Pictures by `Copyright 2016 Karl Cordes`
> license?
CC-by SA 4.0 as states in the commit message.

BTW don't we need to add # Copyright to each file or to a separate COPYRIGHT file ?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29936
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06618092817b91062b35f3b054a82cf573f641b8
Gerrit-Change-Number: 29936
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-CC: Patrick Georgi <pgeorgi at google.com>
Gerrit-Comment-Date: Wed, 19 Dec 2018 13:02:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Comment-In-Reply-To: Patrick Georgi <pgeorgi at google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/502f0c1d/attachment.html>