[coreboot-gerrit] Change in ...coreboot[master]: Documentation/gerrit: Update parts about WIP and draft commits

[Patrick Georgi (Code Review)]

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30309


Change subject: Documentation/gerrit: Update parts about WIP and draft commits
......................................................................

Documentation/gerrit: Update parts about WIP and draft commits

Gerrit dropped the "draft" concept and replaced it with private commits
and work-in-progress commits, options that can be used independently
from each other.

Change-Id: I6abe267c2091c750fc234057be3a4e62adb59c4c
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
M Documentation/getting_started/gerrit_guidelines.md
1 file changed, 9 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/30309/1

diff --git a/Documentation/getting_started/gerrit_guidelines.md b/Documentation/getting_started/gerrit_guidelines.md
index ba2b7b9..34104d8 100644
--- a/Documentation/getting_started/gerrit_guidelines.md
+++ b/Documentation/getting_started/gerrit_guidelines.md
@@ -159,15 +159,19 @@
 commit message can be updated easily when it’s ready to be pushed.
 Examples of this are "WIP: title" or "[NEEDS_TEST]: title".  Another way to
 mark the patch as not ready would be to give it a -1 or -2 review, but
-isn't as obvious as the commit message. These patches can also be pushed as
-drafts as shown in the next guideline.
+isn't as obvious as the commit message. These patches can also be pushed with
+the wip flag:
+	git push origin HEAD:refs/for/master%wip
 
 * When pushing patches that are not for submission, these should be marked
 as such. This can be done in the title ‘[DONOTSUBMIT]’, or can be pushed as
-draft commits, so that only explicitly added reviewers will see them. These
+private changes, so that only explicitly added reviewers will see them. These
 sorts of patches are frequently posted as ideas or RFCs for the community
-to look at. To push a draft, use the command:
-        git push origin HEAD:refs/for/master%private,wip
+to look at. To push a private change, use the command:
+        git push origin HEAD:refs/for/master%private
+
+* Multiple push options can be combined:
+        git push origin HEAD:refs/for/master%private,wip,topic=experiment
 
 * Respond to anyone who has taken the time to review your patches, even if
 it's just to say that you disagree. While it may seem annoying to address a

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30309
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6abe267c2091c750fc234057be3a4e62adb59c4c
Gerrit-Change-Number: 30309
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/1c5172e5/attachment.html>