[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Add EC trigger events and acpi configs

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30281 )

Change subject: mb/google/hatch: Add EC trigger events and acpi configs
......................................................................


Patch Set 8:

(5 comments)

https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h 
File src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h:

https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@19 
PS7, Line 19: include <ec/googl
> What is this required for?
Not required. Removed.


https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@21 
PS7, Line 21: 
> What is this required for?
to include GPE_EC_WAKE definition.


https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@36 
PS7, Line 36: 	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE)       |\
> No EC_HOST_EVENT_PD_MCU?
added here EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)


https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@79 
PS7, Line 79: 
> Do you plan to enable tablet motion control device later on? If yes, can you please file a bug for t […]
if it is needed, I can revise the patch and include.


https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h 
File src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h:

https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h@28 
PS7, Line 28: special DeepSX wake pin
> not true on this platform.
Sorry, not sure if I understood. Is it about the comment or the GPE assignment?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a86f609c269cb59e546fc7ba4ba032e5ea8341a
Gerrit-Change-Number: 30281
Gerrit-PatchSet: 8
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 19 Dec 2018 09:50:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan at google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/38ef3c65/attachment.html>