[coreboot-gerrit] Change in ...coreboot[master]: soc/amd/stoneyridge: Get rid of device_t

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30044 )

Change subject: soc/amd/stoneyridge: Get rid of device_t
......................................................................


Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/30044/6/src/soc/amd/stoneyridge/southbridge.c 
File src/soc/amd/stoneyridge/southbridge.c:

https://review.coreboot.org/#/c/30044/6/src/soc/amd/stoneyridge/southbridge.c@704 
PS6, Line 704: void sb_enable(pci_devfn_t dev)
it seems like this function is only called from chip.c, which is only built for ramstage, so it should never be built as SIMPLE_DEVICE?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30044
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d6dce29591f134f64983387c3b268019d52a602
Gerrit-Change-Number: 30044
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi at google.com>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Wed, 19 Dec 2018 06:09:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/9cf14d71/attachment.html>