[coreboot-gerrit] Change in ...coreboot[master]: mb/asrock/h81m-hds: Allow "keep state" for power_on_after_fail

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30102 )

Change subject: mb/asrock/h81m-hds: Allow "keep state" for power_on_after_fail
......................................................................

mb/asrock/h81m-hds: Allow "keep state" for power_on_after_fail

When I added the cmos.layout file, I did not realise that the
southbridge code cleverly emulated the "keep state" option.

Tested on an ASRock H81M-HDS. The `Keep` option works as it should.

Change-Id: I908e59d1e1eedefa6610e7f980afc3c04390a519
Signed-off-by: Tristan Corrick <tristan at corrick.kiwi>
Reviewed-on: https://review.coreboot.org/c/30102
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/asrock/h81m-hds/cmos.layout
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved



diff --git a/src/mainboard/asrock/h81m-hds/cmos.layout b/src/mainboard/asrock/h81m-hds/cmos.layout
index c7947f7..4926a45 100644
--- a/src/mainboard/asrock/h81m-hds/cmos.layout
+++ b/src/mainboard/asrock/h81m-hds/cmos.layout
@@ -55,7 +55,7 @@
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
-409          2       e       1        power_on_after_fail
+409          2       e       5        power_on_after_fail
 
 # coreboot config options: check sums
 984          16      h       0        check_sum
@@ -84,6 +84,10 @@
 4     7     Debug
 4     8     Spew
 
+5     0     Disable
+5     1     Enable
+5     2     Keep
+
 # -----------------------------------------------------------------
 checksums
 

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I908e59d1e1eedefa6610e7f980afc3c04390a519
Gerrit-Change-Number: 30102
Gerrit-PatchSet: 4
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/5a0dcbbe/attachment.html>