[coreboot-gerrit] Change in ...coreboot[master]: {device, drivers}: Remove useless include <device/pci_ids.h>

Patrick Georgi (Code Review) gerrit at coreboot.org
Wed Dec 19 06:22:48 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30203 )

Change subject: {device,drivers}: Remove useless include <device/pci_ids.h>
......................................................................

{device,drivers}: Remove useless include <device/pci_ids.h>

Change-Id: Ib96bf7d48711f518e36f8d12244b5749d84a0f68
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
Reviewed-on: https://review.coreboot.org/c/30203
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M src/device/azalia_device.c
M src/device/oprom/realmode/x86_interrupts.c
M src/device/pci_ops.c
M src/device/pci_ops_mmconf.c
M src/device/pcix_device.c
M src/drivers/aspeed/common/aspeed_coreboot.h
M src/drivers/sil/3114/sil_sata.c
M src/drivers/xgi/common/xgi_coreboot.h
8 files changed, 0 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved



diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c
index 5c2fcfc..364eec1 100644
--- a/src/device/azalia_device.c
+++ b/src/device/azalia_device.c
@@ -16,7 +16,6 @@
 #include <console/console.h>
 #include <device/device.h>
 #include <device/pci.h>
-#include <device/pci_ids.h>
 #include <device/pci_ops.h>
 #include <device/azalia_device.h>
 #include <arch/io.h>
diff --git a/src/device/oprom/realmode/x86_interrupts.c b/src/device/oprom/realmode/x86_interrupts.c
index 7ec77f8..e70b25d 100644
--- a/src/device/oprom/realmode/x86_interrupts.c
+++ b/src/device/oprom/realmode/x86_interrupts.c
@@ -19,7 +19,6 @@
 #include <arch/registers.h>
 #include <console/console.h>
 #include <device/pci.h>
-#include <device/pci_ids.h>
 #include <device/pci_ops.h>
 #include <string.h>
 
diff --git a/src/device/pci_ops.c b/src/device/pci_ops.c
index 202a9cd..82c22a7 100644
--- a/src/device/pci_ops.c
+++ b/src/device/pci_ops.c
@@ -17,7 +17,6 @@
 
 #include <console/console.h>
 #include <device/pci.h>
-#include <device/pci_ids.h>
 #include <device/pci_ops.h>
 
 static const struct pci_bus_operations *pci_bus_ops(struct bus *bus, struct device *dev)
diff --git a/src/device/pci_ops_mmconf.c b/src/device/pci_ops_mmconf.c
index abbab3f..04f3d23 100644
--- a/src/device/pci_ops_mmconf.c
+++ b/src/device/pci_ops_mmconf.c
@@ -13,7 +13,6 @@
 
 #include <arch/io.h>
 #include <device/pci.h>
-#include <device/pci_ids.h>
 #include <device/pci_ops.h>
 
 #if !defined(CONFIG_MMCONF_BASE_ADDRESS) || !CONFIG_MMCONF_BASE_ADDRESS
diff --git a/src/device/pcix_device.c b/src/device/pcix_device.c
index 31b74e5..1204660 100644
--- a/src/device/pcix_device.c
+++ b/src/device/pcix_device.c
@@ -17,7 +17,6 @@
 #include <console/console.h>
 #include <device/device.h>
 #include <device/pci.h>
-#include <device/pci_ids.h>
 #include <device/pcix.h>
 
 static void pcix_tune_dev(struct device *dev)
diff --git a/src/drivers/aspeed/common/aspeed_coreboot.h b/src/drivers/aspeed/common/aspeed_coreboot.h
index b974840..4798ec2 100644
--- a/src/drivers/aspeed/common/aspeed_coreboot.h
+++ b/src/drivers/aspeed/common/aspeed_coreboot.h
@@ -26,7 +26,6 @@
 #include <console/console.h>
 #include <device/device.h>
 #include <device/pci.h>
-#include <device/pci_ids.h>
 #include <device/pci_ops.h>
 
 /* coreboot <--> kernel code interface */
diff --git a/src/drivers/sil/3114/sil_sata.c b/src/drivers/sil/3114/sil_sata.c
index 3c56266..95499a7 100644
--- a/src/drivers/sil/3114/sil_sata.c
+++ b/src/drivers/sil/3114/sil_sata.c
@@ -22,7 +22,6 @@
 #include <console/console.h>
 #include <device/device.h>
 #include <device/pci.h>
-#include <device/pci_ids.h>
 #include <device/pci_ops.h>
 
 static void si_sata_init(struct device *dev)
diff --git a/src/drivers/xgi/common/xgi_coreboot.h b/src/drivers/xgi/common/xgi_coreboot.h
index b9332e8..6c0fd6c 100644
--- a/src/drivers/xgi/common/xgi_coreboot.h
+++ b/src/drivers/xgi/common/xgi_coreboot.h
@@ -28,7 +28,6 @@
 #include <console/console.h>
 #include <device/device.h>
 #include <device/pci.h>
-#include <device/pci_ids.h>
 #include <device/pci_ops.h>
 
 #include "initdef.h"

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30203
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib96bf7d48711f518e36f8d12244b5749d84a0f68
Gerrit-Change-Number: 30203
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/08b2ccaa/attachment.html>


More information about the coreboot-gerrit mailing list