[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Add SoC and EC asl files in DSDT
Furquan Shaikh (Code Review)
gerrit at coreboot.org
Tue Dec 18 23:42:30 CET 2018
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30282 )
Change subject: mb/google/hatch: Add SoC and EC asl files in DSDT
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/30282/7/src/mainboard/google/hatch/dsdt.asl
File src/mainboard/google/hatch/dsdt.asl:
https://review.coreboot.org/#/c/30282/7/src/mainboard/google/hatch/dsdt.asl@29
PS7, Line 29: // Some generic macros
Above lines use /* */ for single line comments. Can you please follow the same convention?
--
To view, visit https://review.coreboot.org/c/coreboot/+/30282
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf1b1d7e34a7e863139c3583903f3b1e2cdc8da6
Gerrit-Change-Number: 30282
Gerrit-PatchSet: 7
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 18 Dec 2018 22:42:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/58cdd825/attachment.html>
More information about the coreboot-gerrit
mailing list