[coreboot-gerrit] Change in ...coreboot[master]: cpu/intel/common: decouple IA32_FEATURE_CONTROL lock from set_vmx()

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30229 )

Change subject: cpu/intel/common: decouple IA32_FEATURE_CONTROL lock from set_vmx()
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

https://review.coreboot.org/#/c/30229/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30229/2//COMMIT_MSG@12 
PS2, Line 12: vmx flag and lock bit, and rename existing function to indiate that
indi*c*ate


https://review.coreboot.org/#/c/30229/2/src/cpu/intel/common/Kconfig 
File src/cpu/intel/common/Kconfig:

https://review.coreboot.org/#/c/30229/2/src/cpu/intel/common/Kconfig@12 
PS2, Line 12: 	default y if ENABLE_VMX
I think it should default to y unconditionally.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30229
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee772fe87306b4729ca012cef8640d3858e2cb06
Gerrit-Change-Number: 30229
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: David Guckian <david.guckian at intel.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 18 Dec 2018 22:18:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/ac5e3406/attachment.html>