[coreboot-gerrit] Change in ...coreboot[master]: cr50: Add probe command to poll Cr50 until DID VID is valid

[Vadim Bendebury (Code Review)]

Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30295 )

Change subject: cr50: Add probe command to poll Cr50 until DID VID is valid
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/30295/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30295/1//COMMIT_MSG@17 
PS1, Line 17: un the Cr50 factory update a
just curious if you checked if fallback to 0.0.22 now boots OK.


https://review.coreboot.org/#/c/30295/1/src/drivers/i2c/tpm/cr50.c 
File src/drivers/i2c/tpm/cr50.c:

https://review.coreboot.org/#/c/30295/1/src/drivers/i2c/tpm/cr50.c@477 
PS1, Line 477: S
> Is this the preferred style?  While this line will compile without the parenthesis around (vendor==C […]
I agree, parens make for better readable code in this case.


https://review.coreboot.org/#/c/30295/1/src/drivers/i2c/tpm/cr50.c@519 
PS1, Line 519: d
> Keith, that makes sense to me.
I understand the desire not to change the debug message flow, but note that each access adds a few milliseconds to the boot time, from this point of view the less accesses the better.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30295
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47c59a32378ad00336277e111e81ba8d2d63e69a
Gerrit-Change-Number: 30295
Gerrit-PatchSet: 2
Gerrit-Owner: Edward Hill <ecgh at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Edward Hill <ecgh at chromium.org>
Gerrit-Reviewer: Keith Short <keithshort at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 18 Dec 2018 19:33:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Keith Short <keithshort at chromium.org>
Comment-In-Reply-To: Raul Rangel <rrangel at chromium.org>
Comment-In-Reply-To: Martin Roth <martinroth at google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/70542056/attachment.html>