[coreboot-gerrit] Change in ...coreboot[master]: cr50: Add probe command to poll Cr50 until DID VID is valid
Edward Hill (Code Review)
gerrit at coreboot.org
Tue Dec 18 19:15:55 CET 2018
Edward Hill has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30295 )
Change subject: cr50: Add probe command to poll Cr50 until DID VID is valid
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/30295/1/src/drivers/i2c/tpm/cr50.c
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/#/c/30295/1/src/drivers/i2c/tpm/cr50.c@519
PS1, Line 519:
> Can we call cr50_i2c_probe again?
Or just delete this second DID_VID read since now we've done it already above in cr50_i2c_probe()?
--
To view, visit https://review.coreboot.org/c/coreboot/+/30295
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47c59a32378ad00336277e111e81ba8d2d63e69a
Gerrit-Change-Number: 30295
Gerrit-PatchSet: 1
Gerrit-Owner: Edward Hill <ecgh at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Edward Hill <ecgh at chromium.org>
Gerrit-Reviewer: Keith Short <keithshort at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 18 Dec 2018 18:15:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel at chromium.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/61593e63/attachment.html>
More information about the coreboot-gerrit
mailing list