[coreboot-gerrit] Change in ...coreboot[master]: drivers/generic: Add PCIe bridge helper

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30215 )

Change subject: drivers/generic: Add PCIe bridge helper
......................................................................


Patch Set 5:

(2 comments)

Nico: You're correct. I'll have to think of something else.

https://review.coreboot.org/#/c/30215/5/src/drivers/generic/temp_pcie_bridge/bridge_ram.c 
File src/drivers/generic/temp_pcie_bridge/bridge_ram.c:

https://review.coreboot.org/#/c/30215/5/src/drivers/generic/temp_pcie_bridge/bridge_ram.c@29 
PS5, Line 29: 
> Why is this needed? Can't you just search for the device by vendor and device id at this point?
Because pci_read_config32 don't work at ramstage unless you have a device defined. There's no BH720 device.

One suggestion (Nico Huber) is to actually create one that will do the initialization (reset) of the BH720, and not check for complition before depthcharge is loaded.


https://review.coreboot.org/#/c/30215/5/src/drivers/generic/temp_pcie_bridge/bridge_rom.c 
File src/drivers/generic/temp_pcie_bridge/bridge_rom.c:

https://review.coreboot.org/#/c/30215/5/src/drivers/generic/temp_pcie_bridge/bridge_rom.c@139 
PS5, Line 139: assumes the bridge was programmed to have the devi on bus 1
> Why?
Because set_bases() sets it to bridge 1.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30215
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaec1fcc4f8db8c3b4cfd3786d3ff589dc9cb22f5
Gerrit-Change-Number: 30215
Gerrit-PatchSet: 5
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Simon Glass <sjg at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Tue, 18 Dec 2018 17:50:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martinroth at google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/96f81e07/attachment.html>