[coreboot-gerrit] Change in ...coreboot[master]: Documentation/lessons/lesson2.md: clarify running make gitconfig

[Michael Bacarella (Code Review)]

Michael Bacarella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30293


Change subject: Documentation/lessons/lesson2.md: clarify running make gitconfig
......................................................................

Documentation/lessons/lesson2.md: clarify running make gitconfig

It's easy to misinterpret or miss altogether the instruction to
run 'make gitconfig', which will cause strange problems a few
commands later.  Revise the documentation to make it clearer.
Also adds a blurb further down with a link to find Gerrit
workflow docs.

Change-Id: I49734c724c4d6da716a358cd849938ef14dab3b1
Signed-off-by: Michael Bacarella <michael.bacarella at gmail.com>

detached from FETCH_HEAD

Change-Id: I7ce93f1554a9e289d65e96f0b6d4d61292ded1f4
---
M Documentation/lessons/lesson2.md
1 file changed, 13 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/30293/1

diff --git a/Documentation/lessons/lesson2.md b/Documentation/lessons/lesson2.md
index a95dd80..c354bfd 100644
--- a/Documentation/lessons/lesson2.md
+++ b/Documentation/lessons/lesson2.md
@@ -71,14 +71,18 @@
 If you are using HTTP, instead, select **http** from the tabs under "Project coreboot"
 and run the command that appears
 
-After it finishes cloning, "cd coreboot" will take you into the local
-git repository. Run "make gitconfig" to set up the hooks and configurations.
-For example, you will be asked to run the following commands to set your
-username and email.
+Now is a good time to configure your global git identity, if you haven't
+already.
 
 	git config --global user.name "Your Name"
 	git config --global user.email "Your Email"
 
+Finally, enter the local git repository and set up repository specific hooks
+and other configurations.
+
+	cd coreboot
+	make gitconfig
+
 ## Part 4: Submit a commit
 
 An easy first commit to make is fixing existing checkpatch errors and warnings
@@ -149,6 +153,11 @@
 your commit will be on coreboot.org, but is only visible to those you add
 as reviewers.
 
+This has been a quick primer on how to submit a change to Gerrit for review
+using git.  You may wish to review the [Gerrit code review workflow
+documentation](https://gerrit-review.googlesource.com/Documentation/intro-user.html#code-review),
+especially if you plan to work on multiple changes at the same time.
+
 ## Part 4b: Using git cola to stage and submit a commit
 
 If git cola is not installed on your machine, see

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30293
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ce93f1554a9e289d65e96f0b6d4d61292ded1f4
Gerrit-Change-Number: 30293
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bacarella <michael.bacarella at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/da46202b/attachment.html>