[coreboot-gerrit] Change in ...coreboot[master]: northbridge: Remove unneeded include <pc80/mc146818rtc.h>
Felix Held (Code Review)
gerrit at coreboot.org
Tue Dec 18 14:49:32 CET 2018
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30195 )
Change subject: northbridge: Remove unneeded include <pc80/mc146818rtc.h>
......................................................................
northbridge: Remove unneeded include <pc80/mc146818rtc.h>
Change-Id: Icae59721db530572d76035975a4e90686bf4fa65
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
Reviewed-on: https://review.coreboot.org/c/30195
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Felix Held <felix-coreboot at felixheld.de>
---
M src/northbridge/amd/amdfam10/nb_control.c
M src/northbridge/intel/haswell/raminit.c
M src/northbridge/intel/pineview/raminit.c
M src/northbridge/intel/x4x/raminit.c
M src/northbridge/intel/x4x/raminit_ddr23.c
M src/northbridge/via/vx900/lpc.c
6 files changed, 0 insertions(+), 6 deletions(-)
Approvals:
build bot (Jenkins): Verified
Felix Held: Looks good to me, approved
diff --git a/src/northbridge/amd/amdfam10/nb_control.c b/src/northbridge/amd/amdfam10/nb_control.c
index 255948d..a9bdb18 100644
--- a/src/northbridge/amd/amdfam10/nb_control.c
+++ b/src/northbridge/amd/amdfam10/nb_control.c
@@ -23,7 +23,6 @@
#include <device/pci.h>
#include <device/pci_ids.h>
#include <device/pci_ops.h>
-#include <pc80/mc146818rtc.h>
#include <cpu/amd/model_10xxx_rev.h>
#include "amdfam10.h"
diff --git a/src/northbridge/intel/haswell/raminit.c b/src/northbridge/intel/haswell/raminit.c
index 221d71f..faaa9d0 100644
--- a/src/northbridge/intel/haswell/raminit.c
+++ b/src/northbridge/intel/haswell/raminit.c
@@ -23,7 +23,6 @@
#include <ip_checksum.h>
#include <memory_info.h>
#include <mrc_cache.h>
-#include <pc80/mc146818rtc.h>
#include <device/pci_def.h>
#include <device/dram/ddr3.h>
#include <smbios.h>
diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c
index f199d9b..512403f 100644
--- a/src/northbridge/intel/pineview/raminit.c
+++ b/src/northbridge/intel/pineview/raminit.c
@@ -22,7 +22,6 @@
#include <lib.h>
#include "pineview.h"
#include "raminit.h"
-#include <pc80/mc146818rtc.h>
#include <spd.h>
#include <string.h>
diff --git a/src/northbridge/intel/x4x/raminit.c b/src/northbridge/intel/x4x/raminit.c
index c97c139..b3b84d8 100644
--- a/src/northbridge/intel/x4x/raminit.c
+++ b/src/northbridge/intel/x4x/raminit.c
@@ -29,7 +29,6 @@
#include <southbridge/intel/i82801jx/i82801jx.h> /* smbus_read_byte */
#endif
#include "x4x.h"
-#include <pc80/mc146818rtc.h>
#include <spd.h>
#include <string.h>
#include <device/dram/ddr2.h>
diff --git a/src/northbridge/intel/x4x/raminit_ddr23.c b/src/northbridge/intel/x4x/raminit_ddr23.c
index 32fa0d9..5c5dafa 100644
--- a/src/northbridge/intel/x4x/raminit_ddr23.c
+++ b/src/northbridge/intel/x4x/raminit_ddr23.c
@@ -20,7 +20,6 @@
#include <console/console.h>
#include <commonlib/helpers.h>
#include <delay.h>
-#include <pc80/mc146818rtc.h>
#if IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801GX)
#include <southbridge/intel/i82801gx/i82801gx.h>
#else
diff --git a/src/northbridge/via/vx900/lpc.c b/src/northbridge/via/vx900/lpc.c
index b9dac56..27e2384 100644
--- a/src/northbridge/via/vx900/lpc.c
+++ b/src/northbridge/via/vx900/lpc.c
@@ -20,7 +20,6 @@
#include <device/pci.h>
#include <device/pci_ids.h>
#include <pc80/i8259.h>
-#include <pc80/mc146818rtc.h>
#include <drivers/generic/ioapic/chip.h>
#include "vx900.h"
--
To view, visit https://review.coreboot.org/c/coreboot/+/30195
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icae59721db530572d76035975a4e90686bf4fa65
Gerrit-Change-Number: 30195
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/06b05944/attachment.html>
More information about the coreboot-gerrit
mailing list