[coreboot-gerrit] Change in ...coreboot[master]: mb/google/kahlee/liara: Document why IOMMU is disabled

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30166 )

Change subject: mb/google/kahlee/liara: Document why IOMMU is disabled
......................................................................

mb/google/kahlee/liara: Document why IOMMU is disabled

Commit d80884ea5a ("mb/google/kahlee: Disable IOMMU") disabled the IOMMU
in all kahlee variants, but omitted the explaining comment only in
liara's devicetree.cb. Copy this comment to liara.

Change-Id: I564013a16217445003467e2a0579abd50597b205
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Reviewed-on: https://review.coreboot.org/c/30166
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Angel Pons <th3fanbus at gmail.com>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M src/mainboard/google/kahlee/variants/liara/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Angel Pons: Looks good to me, but someone else must approve



diff --git a/src/mainboard/google/kahlee/variants/liara/devicetree.cb b/src/mainboard/google/kahlee/variants/liara/devicetree.cb
index eef984a..bc6c643 100644
--- a/src/mainboard/google/kahlee/variants/liara/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/liara/devicetree.cb
@@ -60,7 +60,7 @@
 	end
 	device domain 0 on
 		device pci 0.0 on  end # Root Complex
-		device pci 0.2 off end # IOMMU
+		device pci 0.2 off end # IOMMU (Disabled for performance and battery)
 		device pci 1.0 on  end # Internal Graphics P2P bridge 0x98e4
 		device pci 1.1 on  end # Internal Multimedia
 		device pci 2.0 on  end # PCIe Host Bridge

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I564013a16217445003467e2a0579abd50597b205
Gerrit-Change-Number: 30166
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/98d07c0e/attachment.html>