[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Enable H1 TPM support over SPI interface

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30210 )

Change subject: mb/google/hatch: Enable H1 TPM support over SPI interface
......................................................................


Patch Set 9:

(8 comments)

https://review.coreboot.org/#/c/30210/9//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30210/9//COMMIT_MSG@7 
PS9, Line 7: Enable H1 TPM support over SPI interface
           : 
This CL is doing much more than just enabling H1 TPM support. Can you please split the clean up part into a separate CL?


https://review.coreboot.org/#/c/30210/9//COMMIT_MSG@10 
PS9, Line 10: mappped
mapped


https://review.coreboot.org/#/c/30210/9//COMMIT_MSG@10 
PS9, Line 10: GPPC_21
GPP_C21


https://review.coreboot.org/#/c/30210/9//COMMIT_MSG@12 
PS9, Line 12: This implementation also cleans up gpio configuration functions
            : and limit definition to baseboard only for now, until variant
            : specfic overides are needed
Can you please split this into a separate CL?


https://review.coreboot.org/#/c/30210/9/src/mainboard/google/hatch/Kconfig 
File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/30210/9/src/mainboard/google/hatch/Kconfig@43 
PS9, Line 43: depends on HATCH_USE_SPI_TPM
Not required. This is always selected.


https://review.coreboot.org/#/c/30210/9/src/mainboard/google/hatch/Kconfig@51 
PS9, Line 51: config HATCH_USE_SPI_TPM
This indirection is not needed. Hatch plans to use SPI for TPM on all variants. MAINBOARD_HAS_SPI_TPM_CR50 and MAINBOARD_HAS_TPM2 can be directly selected above.


https://review.coreboot.org/#/c/30210/9/src/mainboard/google/hatch/variants/baseboard/gpio.c 
File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/30210/9/src/mainboard/google/hatch/variants/baseboard/gpio.c@31 
PS9, Line 31: EDGE_SINGLE
This should be LEVEL


https://review.coreboot.org/#/c/30210/9/src/mainboard/google/hatch/variants/baseboard/gpio.c@31 
PS9, Line 31: UP_20K
Why is this pull required? There is already an external pull present.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30210
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib63a0b473f632d91745102ebd01993e8d65b9552
Gerrit-Change-Number: 30210
Gerrit-PatchSet: 9
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 18 Dec 2018 09:29:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/1e0c9882/attachment.html>