[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Add memory init setup for hatch

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30248 )

Change subject: mb/google/hatch: Add memory init setup for hatch
......................................................................


Patch Set 6:

(4 comments)

https://review.coreboot.org/#/c/30248/2/src/mainboard/google/hatch/Kconfig 
File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/30248/2/src/mainboard/google/hatch/Kconfig@a9 
PS2, Line 9: 
> if u remove this then S3 won't work, is that expected ? if yes then i would expect this to be part o […]
removed it as spd.bin in now getting added in cbfs via Makefile.inc in spd directory


https://review.coreboot.org/#/c/30248/2/src/mainboard/google/hatch/Kconfig@a16 
PS2, Line 16: 
> why this line is missing ?
This is not removed.


https://review.coreboot.org/#/c/30248/2/src/mainboard/google/hatch/romstage.c 
File src/mainboard/google/hatch/romstage.c:

https://review.coreboot.org/#/c/30248/2/src/mainboard/google/hatch/romstage.c@28 
PS2, Line 28: variant_memory_params
> can go to above line ?
no,exceeds 80


https://review.coreboot.org/#/c/30248/2/src/mainboard/google/hatch/variants/baseboard/memory.c 
File src/mainboard/google/hatch/variants/baseboard/memory.c:

https://review.coreboot.org/#/c/30248/2/src/mainboard/google/hatch/variants/baseboard/memory.c@39 
PS2, Line 39: vref_ca_config
> kindly crosscheck this value for ddr4?
I had set it up as per this:
	 * VREF_CA configuraation.
	 * Set to 0 VREF_CA goes to both CH_A and CH_B,
	 * set to 1 VREF_CA goes to CH_A and VREF_DQ_A goes to CH_B,
	 * set to 2 VREF_CA goes to CH_A and VREF_DQ_B goes to CH_B.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30248
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9bda08bd0b9f91ebb96b39291e15473492a6bf19
Gerrit-Change-Number: 30248
Gerrit-PatchSet: 6
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 18 Dec 2018 08:38:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik at intel.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/4b0750e1/attachment.html>