[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Enable H1 TPM support over SPI interface

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30210 )

Change subject: mb/google/hatch: Enable H1 TPM support over SPI interface
......................................................................


Patch Set 9:

(2 comments)

https://review.coreboot.org/#/c/30210/5/src/mainboard/google/hatch/variants/baseboard/devicetree.cb 
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

https://review.coreboot.org/#/c/30210/5/src/mainboard/google/hatch/variants/baseboard/devicetree.cb@22 
PS5, Line 22: 			.speed_mhz = 1,
> this is out of context line, not for h1 for sure :)
Done. Removed


https://review.coreboot.org/#/c/30210/5/src/mainboard/google/hatch/variants/baseboard/gpio.c 
File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/30210/5/src/mainboard/google/hatch/variants/baseboard/gpio.c@44 
PS5, Line 44: 	/* H1_SLAVE_SPI_CLK */
> one extra line is here ?
Done. removed



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30210
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib63a0b473f632d91745102ebd01993e8d65b9552
Gerrit-Change-Number: 30210
Gerrit-PatchSet: 9
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 18 Dec 2018 08:32:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik at intel.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/b2aaaa57/attachment.html>