[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 )

Change subject: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs
......................................................................


Patch Set 46:

(7 comments)

https://review.coreboot.org/#/c/25634/46/src/soc/intel/common/block/cpu/mp_service_ppi.c 
File src/soc/intel/common/block/cpu/mp_service_ppi.c:

https://review.coreboot.org/#/c/25634/46/src/soc/intel/common/block/cpu/mp_service_ppi.c@28 
PS46, Line 28: 	EFI_PEI_SERVICES **ignored1, EFI_PEI_MP_SERVICES_PPI *ignored2,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/46/src/soc/intel/common/block/cpu/mp_service_ppi.c@41 
PS46, Line 41: static EFI_STATUS mp_get_processor_info(CONST EFI_PEI_SERVICES **ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/46/src/soc/intel/common/block/cpu/mp_service_ppi.c@66 
PS46, Line 66: static EFI_STATUS mp_startup_all_aps(CONST EFI_PEI_SERVICES **ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/46/src/soc/intel/common/block/cpu/mp_service_ppi.c@85 
PS46, Line 85: static EFI_STATUS mp_startup_this_ap(CONST EFI_PEI_SERVICES **ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/46/src/soc/intel/common/block/cpu/mp_service_ppi.c@111 
PS46, Line 111: static EFI_STATUS mp_switch_bsp(CONST EFI_PEI_SERVICES **ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/46/src/soc/intel/common/block/cpu/mp_service_ppi.c@119 
PS46, Line 119: static EFI_STATUS mp_enable_disable_ap(CONST EFI_PEI_SERVICES **ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/46/src/soc/intel/common/block/cpu/mp_service_ppi.c@126 
PS46, Line 126: static EFI_STATUS mp_identify_processor(CONST EFI_PEI_SERVICES **PeiServices,
need consistent spacing around '*' (ctx:WxO)



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/25634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956
Gerrit-Change-Number: 25634
Gerrit-PatchSet: 46
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Idwer Vollering <vidwer at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich at gmail.com>
Gerrit-CC: Aaron Durbin <adurbin at chromium.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone at intel.com>
Gerrit-Comment-Date: Tue, 18 Dec 2018 08:19:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/3c0381b0/attachment.html>