[coreboot-gerrit] Change in ...coreboot[master]: drivers: Add eMMC reset driver

Richard Spiegel (Code Review) gerrit at coreboot.org
Mon Dec 17 18:18:42 CET 2018


Hello Patrick Rudolph, Simon Glass, build bot (Jenkins), Daniel Kurtz, Raul Rangel, Patrick Georgi, Martin Roth, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/30225

to look at the new patch set (#3).

Change subject: drivers: Add eMMC reset driver
......................................................................

drivers: Add eMMC reset driver

The eMMC takes a long time to reset. To improve boot speed, create code
that starts reset as early as possible, and checks for reset completion
just before starting payload. This code should pass this information to
the payload through cbmem, so it can know reset was issued, where it's
(completed/pending) and take appropriate action (not starting reset a
second time). This might save up to 100 milliseconds (exact value TBD).

BUG=b:118680303
TEST=Added debug code to call both functions and analyze its effects.
Build and boot grunt.

Change-Id: I4bb55fde23e3b70da1cca76e5672e880317b8bd2
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/commonlib/include/commonlib/cbmem_id.h
A src/drivers/emmc/Kconfig
A src/drivers/emmc/Makefile.inc
A src/drivers/emmc/emmc_ram.c
A src/drivers/emmc/emmc_rom.c
A src/include/device/emmc.h
6 files changed, 154 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/30225/3
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30225
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bb55fde23e3b70da1cca76e5672e880317b8bd2
Gerrit-Change-Number: 30225
Gerrit-PatchSet: 3
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Simon Glass <sjg at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181217/f0180b70/attachment.html>


More information about the coreboot-gerrit mailing list