[coreboot-gerrit] Change in ...coreboot[master]: drivers/generic: Add PCIe bridge helper

Richard Spiegel (Code Review) gerrit at coreboot.org
Mon Dec 17 17:58:41 CET 2018


Hello Patrick Rudolph, Simon Glass, build bot (Jenkins), Daniel Kurtz, Raul Rangel, Patrick Georgi, Martin Roth, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/30215

to look at the new patch set (#5).

Change subject: drivers/generic: Add PCIe bridge helper
......................................................................

drivers/generic: Add PCIe bridge helper

Sometimes you need to send commands to a device behind a PCIe bridge still
at romstage, but bridge is not yet programmed. You need to temporarily program
the bridge and any base address. Then you send whatever command, and disable
the bridge, so regular PCI enumeration can do the work without bothering with
something previous. Finally, some time later, you have to send a second command,
or maybe read a register, but now PCI was enumerated... so you need to check
where the base address was placed.

BUG=b:118680303
TEST=Added debug code to call all 3 functions and analyze its effects.
Build and boot grunt.

Change-Id: Iaec1fcc4f8db8c3b4cfd3786d3ff589dc9cb22f5
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
A src/drivers/generic/temp_pcie_bridge/Kconfig
A src/drivers/generic/temp_pcie_bridge/Makefile.inc
A src/drivers/generic/temp_pcie_bridge/README
A src/drivers/generic/temp_pcie_bridge/bridge_ram.c
A src/drivers/generic/temp_pcie_bridge/bridge_rom.c
A src/include/device/temp_bridge.h
6 files changed, 310 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/30215/5
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30215
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaec1fcc4f8db8c3b4cfd3786d3ff589dc9cb22f5
Gerrit-Change-Number: 30215
Gerrit-PatchSet: 5
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Simon Glass <sjg at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181217/cfa232e7/attachment.html>


More information about the coreboot-gerrit mailing list