[coreboot-gerrit] Change in ...coreboot[master]: cpu/intel/speedstep: Add Netburst

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Dec 17 13:24:26 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22604 )

Change subject: cpu/intel/speedstep: Add Netburst
......................................................................


Patch Set 48:

(3 comments)

https://review.coreboot.org/#/c/22604/48/src/cpu/intel/speedstep/acpi.c 
File src/cpu/intel/speedstep/acpi.c:

https://review.coreboot.org/#/c/22604/48/src/cpu/intel/speedstep/acpi.c@63 
PS48, Line 63: 	if (fsb3 =< 0)
spaces required around that '=' (ctx:WxO)


https://review.coreboot.org/#/c/22604/48/src/cpu/intel/speedstep/acpi.c@63 
PS48, Line 63: 	if (fsb3 =< 0)
spaces required around that '<' (ctx:OxW)


https://review.coreboot.org/#/c/22604/48/src/cpu/intel/speedstep/acpi.c@63 
PS48, Line 63: 	if (fsb3 =< 0)
do not use assignment in if condition



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/22604
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a
Gerrit-Change-Number: 22604
Gerrit-PatchSet: 48
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 17 Dec 2018 12:24:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181217/b7d705af/attachment.html>


More information about the coreboot-gerrit mailing list