[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/haswell: Don't unconditionally set DEVEN

[Tristan Corrick (Code Review)]

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30269 )

Change subject: nb/intel/haswell: Don't unconditionally set DEVEN
......................................................................


Patch Set 2:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > > Patch Set 1:
> > > 
> > > I'd merge this patch last, to prevent possible regressions.
> > 
> > I don't understand how merging it last would prevent regressions. Also,
> > the other patches in the series depend on this to work.
> > 
> > I've set the series as WIP since I don't want any of it to be merged
> > until after the 4.9 release.
> 
> It should be merged after If1504e620967449a09f113a7c771a1ec30380644. That will make sure the behaviour (enabled/disabled northbridge devices) is the same regardless which commit is checkout for regression testing, assuming the devicetree's of haswell boards mirror the current DEVEN setting.

That makes sense, thank you. I've changed the order of the patches.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I242f9138472de5a0b26b5852f632b53b2920132d
Gerrit-Change-Number: 30269
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 17 Dec 2018 10:52:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181217/0cb4249f/attachment.html>