[coreboot-gerrit] Change in ...coreboot[master]: mb/foxconn/g41s-k: Add g41m variant

Arthur Heymans (Code Review) gerrit at coreboot.org
Mon Dec 17 10:51:55 CET 2018


Hello build bot (Jenkins), Patrick Georgi, Martin Roth, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/30242

to look at the new patch set (#7).

Change subject: mb/foxconn/g41s-k: Add g41m variant
......................................................................

mb/foxconn/g41s-k: Add g41m variant

Was tested with the following:
- 2 DIMM slots
- USB
- Ethernet NIC
- automatic fan control
- Libgfxinit with VGA, DVI (HDMI slot unpopulated)
- PS2 Keyboard
- SATA
- PEG
- S3 resume

What does not work:
- Using the second DIMM slot on a channel
  G41 can only handle 2 ranks per channel and on this mainboard 1 rank
  per DIMM slot. Supporting this would require too much raminit rework
  and is not worth it (at least for me)

Change-Id: I67784038ef929f561b82365f00db70a69c024321
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/foxconn/g41s-k/Kconfig
M src/mainboard/foxconn/g41s-k/Kconfig.name
M src/mainboard/foxconn/g41s-k/Makefile.inc
M src/mainboard/foxconn/g41s-k/acpi/superio.asl
M src/mainboard/foxconn/g41s-k/hda_verb.c
M src/mainboard/foxconn/g41s-k/romstage.c
A src/mainboard/foxconn/g41s-k/variants/g41m/acpi/ich7_pci_irqs.asl
A src/mainboard/foxconn/g41s-k/variants/g41m/data.vbt
A src/mainboard/foxconn/g41s-k/variants/g41m/devicetree.cb
A src/mainboard/foxconn/g41s-k/variants/g41m/gma-mainboard.ads
R src/mainboard/foxconn/g41s-k/variants/g41s-k/acpi/ich7_pci_irqs.asl
R src/mainboard/foxconn/g41s-k/variants/g41s-k/data.vbt
R src/mainboard/foxconn/g41s-k/variants/g41s-k/devicetree.cb
R src/mainboard/foxconn/g41s-k/variants/g41s-k/gma-mainboard.ads
14 files changed, 293 insertions(+), 5 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/30242/7
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30242
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67784038ef929f561b82365f00db70a69c024321
Gerrit-Change-Number: 30242
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181217/5eec28d9/attachment.html>


More information about the coreboot-gerrit mailing list