[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/i82801gx: Autodisable functions based on devicetree

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30244 )

Change subject: sb/intel/i82801gx: Autodisable functions based on devicetree
......................................................................


Patch Set 7:

(1 comment)

I've tested this patch and by mistake, I've set device 00:1b.0 enabled. so the system hang after 00:1e.3 init. (I don't know why).

https://review.coreboot.org/#/c/30244/7/src/southbridge/intel/i82801gx/i82801gx.c 
File src/southbridge/intel/i82801gx/i82801gx.c:

https://review.coreboot.org/#/c/30244/7/src/southbridge/intel/i82801gx/i82801gx.c@47 
PS7, Line 47: FD_ACMOD
FD_ACAUD ?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30244
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I83576599538a02d295fe00b35826f98d8c97d1cf
Gerrit-Change-Number: 30244
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Comment-Date: Sun, 16 Dec 2018 19:12:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181216/6be3643f/attachment.html>