[coreboot-gerrit] Change in ...coreboot[master]: util/superiotool/ite.c: add IT8772 register dump

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30224 )

Change subject: util/superiotool/ite.c: add IT8772 register dump
......................................................................


Patch Set 1:

(1 comment)

> Patch Set 1:
> 
> found some bugs and it seems to be a reimplementation of the first half of #23209

I did not check gerrit prior to making this. I have this chip on a board and found superiotool doesn't have a register dump of it yet.

https://review.coreboot.org/#/c/30224/1/util/superiotool/ite.c 
File util/superiotool/ite.c:

https://review.coreboot.org/#/c/30224/1/util/superiotool/ite.c@874 
PS1, Line 874: ,
> 0xe9 is missing
It is not in my datasheet.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30224
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d74984f453c47d6ec71963a7dcab961a22a5964
Gerrit-Change-Number: 30224
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Comment-Date: Sun, 16 Dec 2018 18:18:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot at felixheld.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181216/58c47ea6/attachment.html>