[coreboot-gerrit] Change in ...coreboot[master]: util/superiotool/ite.c: add IT8772 register dump

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30224 )

Change subject: util/superiotool/ite.c: add IT8772 register dump
......................................................................


Patch Set 1:

(6 comments)

https://review.coreboot.org/#/c/30224/1/util/superiotool/ite.c 
File util/superiotool/ite.c:

https://review.coreboot.org/#/c/30224/1/util/superiotool/ite.c@856 
PS1, Line 856: 0x30,0x60,0x61,0x70,0xf0,0xf1,EOT},
             : 			{0x00,0x03,0xf8,0x04,0x00,0x50,EOT}},
> can you give a try to this ? […]
the chip only has one serial port (don't know if the same die is used in a bigger package that has a second serial port bonded out)


https://review.coreboot.org/#/c/30224/1/util/superiotool/ite.c@874 
PS1, Line 874: ,
0xe9 is missing


https://review.coreboot.org/#/c/30224/1/util/superiotool/ite.c@877 
PS1, Line 877: 0x03
0x01


https://review.coreboot.org/#/c/30224/1/util/superiotool/ite.c@878 
PS1, Line 878: MISC
0x20


https://review.coreboot.org/#/c/30224/1/util/superiotool/ite.c@880 
PS1, Line 880: 0x00
0x40


https://review.coreboot.org/#/c/30224/1/util/superiotool/ite.c@881 
PS1, Line 881: 0x40
0x00



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30224
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d74984f453c47d6ec71963a7dcab961a22a5964
Gerrit-Change-Number: 30224
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Comment-Date: Sun, 16 Dec 2018 17:27:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181216/d11bcfcd/attachment.html>