[coreboot-gerrit] Change in ...coreboot[master]: mb/lenovo/thinkcentre_a58: Add mainboard

[Tristan Corrick (Code Review)]

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30239 )

Change subject: mb/lenovo/thinkcentre_a58: Add mainboard
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/30239/1/src/mainboard/lenovo/thinkcentre_a58/board_info.txt 
File src/mainboard/lenovo/thinkcentre_a58/board_info.txt:

https://review.coreboot.org/#/c/30239/1/src/mainboard/lenovo/thinkcentre_a58/board_info.txt@2 
PS1, Line 2: https://ark.intel.com/products/48621/Intel-Desktop-Board-DG41WV
Is this URL correct?


https://review.coreboot.org/#/c/30239/1/src/mainboard/lenovo/thinkcentre_a58/cmos.layout 
File src/mainboard/lenovo/thinkcentre_a58/cmos.layout:

https://review.coreboot.org/#/c/30239/1/src/mainboard/lenovo/thinkcentre_a58/cmos.layout@81 
PS1, Line 81: 6     1     Emergency
            : 6     2     Alert
            : 6     3     Critical
            : 6     4     Error
            : 6     5     Warning
            : 6     6     Notice
            : 6     7     Info
            : 6     8     Debug
            : 6     9     Spew
These are off by 1.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30239
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I483e1143e4095b8a58fed142d31ca7f233a854e2
Gerrit-Change-Number: 30239
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 16 Dec 2018 02:04:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181216/6398e68b/attachment.html>