[coreboot-gerrit] Change in ...coreboot[master]: mb/foxconn/g41s-k: Don't reprogramm enherited subsystemid

Arthur Heymans (Code Review) gerrit at coreboot.org
Sat Dec 15 21:57:45 CET 2018


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30241


Change subject: mb/foxconn/g41s-k: Don't reprogramm enherited subsystemid
......................................................................

mb/foxconn/g41s-k: Don't reprogramm enherited subsystemid

Change-Id: I85b5aef758a1ed30c46ed0adabec3293edb0f3fd
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/foxconn/g41s-k/devicetree.cb
1 file changed, 10 insertions(+), 31 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/30241/1

diff --git a/src/mainboard/foxconn/g41s-k/devicetree.cb b/src/mainboard/foxconn/g41s-k/devicetree.cb
index a638457..9f3b7ba 100644
--- a/src/mainboard/foxconn/g41s-k/devicetree.cb
+++ b/src/mainboard/foxconn/g41s-k/devicetree.cb
@@ -31,9 +31,7 @@
 			subsystemid 0x105b 0x0dda
 		end
 		device pci 1.0 on end			# PEG
-		device pci 2.0 on			# Integrated graphics controller
-			subsystemid 0x105b 0x0dda
-		end
+		device pci 2.0 on end			# Integrated graphics controller
 		device pci 2.1 off end			# Integrated graphics controller 2
 		device pci 3.0 off end			# ME
 		device pci 3.1 off end			# ME
@@ -55,39 +53,24 @@
 			register "sata_ahci" = "0x0"	# AHCI does not work
 			register "sata_ports_implemented" = "0x3"
 
-			device pci 1b.0 on		# Audio
-				subsystemid 0x105b 0x0dda
-			end
+			device pci 1b.0 on end		# Audio
 			device pci 1c.0 on end		# PCIe 1
 			device pci 1c.1 on		# PCIe 2 (NIC)
-				device pci 00.0 on		# PCI 10ec:8168
-					subsystemid 0x105b 0x0dda
-				end
+				device pci 00.0 on end		# PCI 10ec:8168
 			end
 			device pci 1c.2 off end		# PCIe 3
 			device pci 1c.3 off end		# PCIe 4
 			device pci 1c.4 off end		# PCIe 5
 			device pci 1c.5 off end		# PCIe 6
-			device pci 1d.0 on		# USB
-				subsystemid 0x105b 0x0dda
-			end
-			device pci 1d.1 on		# USB
-				subsystemid 0x105b 0x0dda
-			end
-			device pci 1d.2 on		# USB
-				subsystemid 0x105b 0x0dda
-			end
-			device pci 1d.3 on		# USB
-				subsystemid 0x105b 0x0dda
-			end
-			device pci 1d.7 on		# USB
-				subsystemid 0x105b 0x0dda
-			end
+			device pci 1d.0 on end		# USB
+			device pci 1d.1 on end		# USB
+			device pci 1d.2 on end		# USB
+			device pci 1d.3 on end		# USB
+			device pci 1d.7 on end		# USB
 			device pci 1e.0 on end		# PCI bridge
 			device pci 1e.2 off end		# AC'97 Audio
 			device pci 1e.3 off end		# AC'97 Modem
 			device pci 1f.0 on		# ISA bridge
-				subsystemid 0x105b 0x0dda
 				chip superio/ite/it8720f	# Super I/O
 					register "TMPIN1.mode" = "THERMAL_DIODE"
 					register "TMPIN1.offset" = "0"
@@ -179,12 +162,8 @@
 				end
 			end
 			device pci 1f.1 off end		# PATA/IDE
-			device pci 1f.2 on		# SATA
-				subsystemid 0x105b 0x0dda
-			end
-			device pci 1f.3 on		# SMbus
-				subsystemid 0x105b 0x0dda
-			end
+			device pci 1f.2 on end		# SATA
+			device pci 1f.3 on end		# SMbus
 		end
 	end
 end

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30241
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85b5aef758a1ed30c46ed0adabec3293edb0f3fd
Gerrit-Change-Number: 30241
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181215/0660f96b/attachment-0001.html>


More information about the coreboot-gerrit mailing list