[coreboot-gerrit] Change in ...coreboot[master]: drivers/net/rt8168: support loading MAC address from vpd.bin

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30231 )

Change subject: drivers/net/rt8168: support loading MAC address from vpd.bin
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30231/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30231/1//COMMIT_MSG@7 
PS1, Line 7: drivers/net/rt8168: support loading MAC address from vpd.bin
> care to explain the rationale to add yet another mechanism?
I'd argue it's the persistence of an existing mechanism, previously implemented at the board level (google/beltino, jehct). We could migrate those boards to use this implementation as well. The main reason for it is to allow for seamless persistence of the VPD region/MAC address when going between stock firmware and upstream coreboot on Chromeboxes (in both directions). The "new" mechanism of reading the MAC from a file in CBFS would make that much more complicated.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30231
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If18ab2cd0148c1272cbe65c2ad8864ddd3b4ddf8
Gerrit-Change-Number: 30231
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Comment-Date: Sat, 15 Dec 2018 18:13:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181215/01e4a0be/attachment.html>