[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/skylake: ensure ACPI opregion restored on S3 with GOP init

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30232 )

Change subject: soc/intel/skylake: ensure ACPI opregion restored on S3 with GOP init
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/30232/1/src/soc/intel/skylake/graphics.c 
File src/soc/intel/skylake/graphics.c:

https://review.coreboot.org/#/c/30232/1/src/soc/intel/skylake/graphics.c@60 
PS1, Line 60: 		reg32 |= PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY | PCI_COMMAND_IO;
line over 80 characters


https://review.coreboot.org/#/c/30232/1/src/soc/intel/skylake/graphics.c@70 
PS1, Line 70: 			/* Initialize PCI device, load/execute BIOS Option ROM */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30232
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38a7f3df476c878e7a78ee6543270d71463cb69d
Gerrit-Change-Number: 30232
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 14 Dec 2018 23:56:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181214/c604b1cc/attachment.html>