[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Enable Elan Trackpad

Shelley Chen (Code Review) gerrit at coreboot.org
Fri Dec 14 23:35:29 CET 2018


Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30227


Change subject: mb/google/hatch: Enable Elan Trackpad
......................................................................

mb/google/hatch: Enable Elan Trackpad

BUG=b:120914069
BRANCH=None
TEST=USE="-intel_mrc" emerge-hatch coreboot

Change-Id: I91db5745d1db16ab4b2fbb7f8c415bd7c1eb29e9
Signed-off-by: Shelley Chen <shchen at google.com>
---
M src/mainboard/google/hatch/variants/baseboard/devicetree.cb
M src/mainboard/google/hatch/variants/hatch/gpio.c
2 files changed, 11 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/30227/1

diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb
index 2c6b492..f934cae 100644
--- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb
@@ -17,6 +17,7 @@
 	#|                   | required to set up a BAR  |
 	#|                   | for TPM communication     |
 	#|                   | before memory is up       |
+	#| I2C0              | Touchpad                  |
 	#+-------------------+---------------------------+
 	register "common_soc_config" = "{
 		.chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT,
@@ -36,7 +37,14 @@
 		device pci 14.0 off end # USB xHCI
 		device pci 14.1 off end # USB xDCI (OTG)
 		device pci 14.5 off end # SDCard
-		device pci 15.0 off end # I2C #0
+		device pci 15.0 on
+			chip drivers/i2c/generic
+				register "hid" = ""ELAN0000""
+				register "desc" = ""ELAN Touchpad""
+				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D21_IRQ)"
+				device i2c 15 on end
+			end
+		end # I2C #0
 		device pci 15.1 off end # I2C #1
 		device pci 15.2 off end # I2C #2
 		device pci 15.3 off end # I2C #3
diff --git a/src/mainboard/google/hatch/variants/hatch/gpio.c b/src/mainboard/google/hatch/variants/hatch/gpio.c
index f9aee5f..3fb1c1c 100644
--- a/src/mainboard/google/hatch/variants/hatch/gpio.c
+++ b/src/mainboard/google/hatch/variants/hatch/gpio.c
@@ -30,7 +30,8 @@
 	PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1),
 	/* H1_PCH_INT_ODL */
 	PAD_CFG_GPI_APIC(GPP_C21, UP_20K, DEEP, EDGE_SINGLE, INVERT),
-
+	/* TRACKPAD_INT_ODL */
+	PAD_CFG_GPI_APIC(GPP_D21, NONE, PLTRST, EDGE_SINGLE, NONE),
 };
 
 /* Early pad configuration in bootblock */

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30227
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91db5745d1db16ab4b2fbb7f8c415bd7c1eb29e9
Gerrit-Change-Number: 30227
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181214/45118d15/attachment.html>


More information about the coreboot-gerrit mailing list