[coreboot-gerrit] Change in ...coreboot[master]: WIP: google: add support for multiple SAR filenames
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Fri Dec 14 19:30:31 CET 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30222 )
Change subject: WIP: google: add support for multiple SAR filenames
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30222/1/src/drivers/intel/wifi/wifi.c
File src/drivers/intel/wifi/wifi.c:
https://review.coreboot.org/#/c/30222/1/src/drivers/intel/wifi/wifi.c@74
PS1, Line 74: const char* get_wifi_sar_cbfs_filename(void)
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/30222/1/src/include/sar.h
File src/include/sar.h:
https://review.coreboot.org/#/c/30222/1/src/include/sar.h@57
PS1, Line 57: const char* get_wifi_sar_cbfs_filename(void);
"foo* bar" should be "foo *bar"
--
To view, visit https://review.coreboot.org/c/coreboot/+/30222
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib852aaaff39f1e9149fa43bf8dc25b2400737ea5
Gerrit-Change-Number: 30222
Gerrit-PatchSet: 1
Gerrit-Owner: Justin TerAvest <teravest at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Justin TerAvest <teravest at chromium.org>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub at chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 14 Dec 2018 18:30:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181214/ba9a7d85/attachment.html>
More information about the coreboot-gerrit
mailing list