[coreboot-gerrit] Change in ...coreboot[master]: WIP: mb/google/octopus: Add custom SAR values for Bobba

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30223 )

Change subject: WIP: mb/google/octopus: Add custom SAR values for Bobba
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/30223/1/src/mainboard/google/octopus/variants/bobba/mainboard.c 
File src/mainboard/google/octopus/variants/bobba/mainboard.c:

https://review.coreboot.org/#/c/30223/1/src/mainboard/google/octopus/variants/bobba/mainboard.c@26 
PS1, Line 26: 			switch (sku_id) {
switch and case should be at the same indent


https://review.coreboot.org/#/c/30223/1/src/mainboard/google/octopus/variants/bobba/mainboard.c@37 
PS1, Line 37: 					filename = "bobba360_sar_wifi_values.hex";
line over 80 characters


https://review.coreboot.org/#/c/30223/1/src/mainboard/google/octopus/variants/bobba/mainboard.c@47 
PS1, Line 47: 					filename = "sparky360_sar_wifi_values.hex";
line over 80 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30223
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I354382d651d65d533459f0ca460ca6fd6de547fd
Gerrit-Change-Number: 30223
Gerrit-PatchSet: 1
Gerrit-Owner: Justin TerAvest <teravest at chromium.org>
Gerrit-Reviewer: Justin TerAvest <teravest at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 14 Dec 2018 18:29:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181214/2e0dd95f/attachment.html>