[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Enable H1 TPM support over SPI interface

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30210 )

Change subject: mb/google/hatch: Enable H1 TPM support over SPI interface
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/30210/2/src/mainboard/google/hatch/variants/hatch/gpio.c 
File src/mainboard/google/hatch/variants/hatch/gpio.c:

https://review.coreboot.org/#/c/30210/2/src/mainboard/google/hatch/variants/hatch/gpio.c@23 
PS2, Line 23: 	/* H1_SLAVE_SPI_CS_L */
            : 	PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1),
            : 	/* H1_SLAVE_SPI_CLK */
            : 	PAD_CFG_NF(GPP_B16, NONE, DEEP, NF1),
            : 	/* H1_SLAVE_SPI_MISO_R */
            : 	PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1),
            : 	/* H1_SLAVE_SPI_MOSI_R */
            : 	PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1),
            : 	/* H1_PCH_INT_ODL */
            : 	PAD_CFG_GPI_APIC(GPP_C21, UP_20K, DEEP, EDGE_SINGLE, INVERT),
            : 
            : };
            : 
            : /* Early pad configuration in bootblock */
            : static const struct pad_config early_gpio_table[] = {
            : 
            : 	/* H1_SLAVE_SPI_CS_L */
            : 	PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1),
            : 	/* H1_SLAVE_SPI_CLK */
            : 	PAD_CFG_NF(GPP_B16, NONE, DEEP, NF1),
            : 	/* H1_SLAVE_SPI_MISO_R */
            : 	PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1),
            : 	/* H1_SLAVE_SPI_MOSI_R */
            : 	PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1),
            : 	/* H1_PCH_INT_ODL */
            : 	PAD_CFG_GPI_APIC(GPP_C21, UP_20K, DEEP, EDGE_SINGLE, INVERT)
> Can you indent these?
Done.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30210
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib63a0b473f632d91745102ebd01993e8d65b9552
Gerrit-Change-Number: 30210
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 14 Dec 2018 18:16:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen <shchen at google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181214/8cb0b2d7/attachment.html>