[coreboot-gerrit] Change in ...coreboot[master]: mb/lenovo/x201: Remove unneeded includes

Peter Lemenkov (Code Review) gerrit at coreboot.org
Fri Dec 14 12:02:20 CET 2018


Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30217


Change subject: mb/lenovo/x201: Remove unneeded includes
......................................................................

mb/lenovo/x201: Remove unneeded includes

Tested: still builds fine.

Change-Id: I1ca4e42bd75a3e84afe8b30a60f02058b590416f
Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>
---
M src/mainboard/lenovo/x201/acpi_tables.c
M src/mainboard/lenovo/x201/dock.c
M src/mainboard/lenovo/x201/mainboard.c
3 files changed, 3 insertions(+), 10 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/30217/1

diff --git a/src/mainboard/lenovo/x201/acpi_tables.c b/src/mainboard/lenovo/x201/acpi_tables.c
index e412503..dd25696 100644
--- a/src/mainboard/lenovo/x201/acpi_tables.c
+++ b/src/mainboard/lenovo/x201/acpi_tables.c
@@ -15,7 +15,6 @@
  * GNU General Public License for more details.
  */
 
-#include <stdint.h>
 #include <southbridge/intel/ibexpeak/nvs.h>
 
 void acpi_create_gnvs(global_nvs_t * gnvs)
diff --git a/src/mainboard/lenovo/x201/dock.c b/src/mainboard/lenovo/x201/dock.c
index a25fc70..9e40938 100644
--- a/src/mainboard/lenovo/x201/dock.c
+++ b/src/mainboard/lenovo/x201/dock.c
@@ -17,7 +17,6 @@
 
 #define __SIMPLE_DEVICE__
 #include <console/console.h>
-#include <arch/io.h>
 #include <device/device.h>
 #include <device/pci.h>
 #include "dock.h"
diff --git a/src/mainboard/lenovo/x201/mainboard.c b/src/mainboard/lenovo/x201/mainboard.c
index 419f817..7759e9a 100644
--- a/src/mainboard/lenovo/x201/mainboard.c
+++ b/src/mainboard/lenovo/x201/mainboard.c
@@ -16,19 +16,14 @@
  * GNU General Public License for more details.
  */
 
-#include <console/console.h>
-#include <device/device.h>
-#include <arch/io.h>
+#include <device/pci.h>
 #include <ec/acpi/ec.h>
 #include <northbridge/intel/nehalem/nehalem.h>
-#include <southbridge/intel/bd82x6x/pch.h>
-
-#include "dock.h"
+#include <arch/acpigen.h>
 #include <drivers/intel/gma/int15.h>
 #include <cpu/x86/lapic.h>
-#include <device/pci.h>
 #include <drivers/lenovo/lenovo.h>
-#include <arch/acpigen.h>
+#include "dock.h"
 
 static acpi_cstate_t cst_entries[] = {
 	{1, 1, 1000, {0x7f, 1, 2, {0}, 1, 0}},

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30217
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ca4e42bd75a3e84afe8b30a60f02058b590416f
Gerrit-Change-Number: 30217
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181214/36017a14/attachment.html>


More information about the coreboot-gerrit mailing list