[coreboot-gerrit] Change in ...coreboot[master]: mainboard/lenovo/t410: Add new port

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/11791 )

Change subject: mainboard/lenovo/t410: Add new port
......................................................................


Patch Set 11:

(10 comments)

https://review.coreboot.org/#/c/11791/11/src/mainboard/lenovo/t410/romstage.c 
File src/mainboard/lenovo/t410/romstage.c:

https://review.coreboot.org/#/c/11791/11/src/mainboard/lenovo/t410/romstage.c@65 
PS11, Line 65: 			  (pci_read_config8(PCH_LPC_DEV, GEN_PMCON_3) & ~2) | 1);
line over 80 characters


https://review.coreboot.org/#/c/11791/11/src/mainboard/lenovo/t410/romstage.c@141 
PS11, Line 141: 	unsigned i;
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/11791/11/src/mainboard/lenovo/t410/romstage.c@271 
PS11, Line 271: 				  pci_read_config8(PCH_LPC_DEV, GEN_PMCON_3) | 2);
line over 80 characters


https://review.coreboot.org/#/c/11791/11/src/mainboard/lenovo/t410/smihandler.c 
File src/mainboard/lenovo/t410/smihandler.c:

https://review.coreboot.org/#/c/11791/11/src/mainboard/lenovo/t410/smihandler.c@51 
PS11, Line 51: 	switch (smif) {
switch and case should be at the same indent


https://review.coreboot.org/#/c/11791/11/src/mainboard/lenovo/t410/smihandler.c@54 
PS11, Line 54: 			udelay(250000);
long udelay - prefer mdelay; see arch/arm/include/asm/delay.h


https://review.coreboot.org/#/c/11791/11/src/mainboard/lenovo/t410/smihandler.c@80 
PS11, Line 80: 	if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0)
do not use assignment in if condition


https://review.coreboot.org/#/c/11791/11/src/mainboard/lenovo/t410/smihandler.c@88 
PS11, Line 88: 	if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10)
do not use assignment in if condition


https://review.coreboot.org/#/c/11791/11/src/mainboard/lenovo/t410/smihandler.c@104 
PS11, Line 104: 	switch (event) {
switch and case should be at the same indent


https://review.coreboot.org/#/c/11791/11/src/mainboard/lenovo/t410/smihandler.c@141 
PS11, Line 141: 	switch (data) {
switch and case should be at the same indent


https://review.coreboot.org/#/c/11791/11/src/mainboard/lenovo/t410/smihandler.c@165 
PS11, Line 165: 			/* we have to use port 0x62/0x66, as 0x1600/0x1604 doesn't
line over 80 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/11791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9d872e643dd242e925bfb46d18076e6ad100995
Gerrit-Change-Number: 11791
Gerrit-PatchSet: 11
Gerrit-Owner: Nicolas Reinecke <nr at das-labor.org>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nicolas Reinecke <nr at das-labor.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Eloy
Gerrit-CC: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-CC: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Comment-Date: Fri, 14 Dec 2018 09:19:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181214/bdcb3b33/attachment.html>