[coreboot-gerrit] Change in ...coreboot[master]: mainboard/google/poppy/variants/rammus: Add touchscreen stop GPIO con...

[Kane Chen (Code Review)]

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30180 )

Change subject: mainboard/google/poppy/variants/rammus: Add touchscreen stop GPIO control to fixed touchscreen function failed on EVT FATP
......................................................................


Patch Set 9:

> Patch Set 4:
> 
> (6 comments)
> 
> > Patch Set 4:
> > 
> > > Patch Set 4:
> > > 
> > > (1 comment)
> > 
> > GPP_E3 is for touchscreen I2C CLK & SDA enable/disable in touchscreen power on sequence . Should we define it to be touchscreen enable pin or touchscreen I2C CLK & SDA enable/disable pin ?
> 
> Code looks fine. Please update the comments as indicated.

We modify commit message and gpio.c GPP_E3 comment indicate. Thanks.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30180
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86452c1445243c499aeaf931dba286db169c5628
Gerrit-Change-Number: 30180
Gerrit-PatchSet: 9
Gerrit-Owner: Kane Chen <kane_chen at pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Kane Chen <kane_chen at pegatron.corp-partner.google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Jerry Chou <jerry_chou at pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu at pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 14 Dec 2018 03:11:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181214/e5c9fe91/attachment.html>