[coreboot-gerrit] Change in ...coreboot[master]: mainboard/google/poppy/variants/rammus: Add touchscreen stop GPIO con...

Kane Chen (Code Review) gerrit at coreboot.org
Fri Dec 14 03:54:55 CET 2018


Hello Zhuohao Lee, build bot (Jenkins), Furquan Shaikh, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/30180

to look at the new patch set (#7).

Change subject: mainboard/google/poppy/variants/rammus: Add touchscreen stop GPIO control to fixed touchscreen function failed on EVT FATP
......................................................................

mainboard/google/poppy/variants/rammus: Add touchscreen stop GPIO control to fixed touchscreen function failed on EVT FATP

According to issue tracker b:119238959 #4 & #6 .
Hardware modify design to make GPP_E3 to be a switch of touchscreen I2C CLK and SDA.
Control GPP_E3 to make touchscreen I2C CLK and SDA keep low during power on initialization
to avoid data transfer during this time. After touchscreen IC initial complete, control
GPP_E3 to high to make touchscreen I2C CLK and SDA work normally.
Depending on touchscreen IC specification, device take 105ms for power on initialization.
Change delay time from 120ms to 105ms.

BUG=b:119238959
BRANCH=firmware-rammus-11275.B
TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage
Flash FW to DUT, run S5 stress test and verify the result

Signed-off-by: YanRu Chen <kane_chen at pegatron.corp-partner.google.com>
Change-Id: I86452c1445243c499aeaf931dba286db169c5628
---
M src/mainboard/google/poppy/variants/rammus/devicetree.cb
M src/mainboard/google/poppy/variants/rammus/gpio.c
2 files changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/30180/7
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30180
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86452c1445243c499aeaf931dba286db169c5628
Gerrit-Change-Number: 30180
Gerrit-PatchSet: 7
Gerrit-Owner: Kane Chen <kane_chen at pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Kane Chen <kane_chen at pegatron.corp-partner.google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Jerry Chou <jerry_chou at pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu at pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181214/372e902c/attachment.html>


More information about the coreboot-gerrit mailing list